Fix incorrect content length for the instrumented source #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The original code used String#length, which returns the length of the string in characters, but the header must be the length of the string in bytes. This was causing errors because the browser was (presumably) truncating the content after receiving a (lower) specific number of bytes than the actual number of bytes in the content.
|
Hmm, travis seems to be reporting an error unrelated to my change. I see in #50 there are attempts to fix it too, so I won't duplicate that effort unless it gets blocked. |
|
Cheers! Thanks for this fix, I learned something new. =) |
jejacks0n
added a commit
that referenced
this pull request
Apr 12, 2013
Fix incorrect content length for the instrumented source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code used String#length, which returns the length of the string in characters, but the header must be the length of the string in bytes. This was causing errors because the browser was (presumably) truncating the content after receiving a (lower) specific number of bytes than the actual number of bytes in the content.