Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need the pihole -g ? #2

Closed
Damien514 opened this issue Jun 1, 2021 · 5 comments
Closed

Do we really need the pihole -g ? #2

Damien514 opened this issue Jun 1, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Damien514
Copy link

Damien514 commented Jun 1, 2021

I was wondering if we really needed the pihole -g command?
As we rsync the whole DB, I think that a simple stop / restart / reload list would be enough, or am I wrong?

Other than that, your script is simple and do all I need. Thanks for that :-)

@jejje
Copy link
Owner

jejje commented Jun 4, 2021

Yes I think you are correct! I'd like to try it out and change it but I can't test it at the moment. I'm setting up my network from the ground up. Have you tried it and it worked?

Thank you for your appreciation, I'm really glad it was useful for you! :)

@Damien514
Copy link
Author

Yes I did, and I can confirm it works very well.
All I changed in your script is removing the pihole -g command and moving the stop pihole-FTL before the RSYNC loop and then pihole-FTL start and pihole reload-lists.

@Damien514
Copy link
Author

Oh, and the crontab you create within the script indicates /etc/pi_rsynch.sh ; I edited it as it should be /etc/pihole/pi_rsynch.sh

:-)

@jejje jejje mentioned this issue Jun 4, 2021
@jejje
Copy link
Owner

jejje commented Jun 4, 2021

I made the changes but I am unable to test it properly, but I did as you suggested and I think it will work just as before and is now better optimized

@jejje jejje self-assigned this Jun 4, 2021
@jejje jejje added the enhancement New feature or request label Jun 4, 2021
@jejje jejje closed this as completed Jun 7, 2021
@jejje
Copy link
Owner

jejje commented Jun 7, 2021

Made changes, please tell me if you find more optimizations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants