Actually Use GSL in CI Tests #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In jekyll#196, I attempted to make the CI tests execute both with and without GSL support because classifier-reborn is supposed to work in both cases (though GSL increases performance). However, while doing so, I missed the fact that `script/test` (which our CI job runs) uses `bundle exec` to run the tests. And when the tests are run with `bundle exec`, Bundler will not load gems that aren't specified in the Gemfile. So our GSL tests weren't actually using the GSL gem. To fix this, we add `gem 'gsl' if ENV["LOAD_GSL"]` to our Gemfile. (This solution was proposed by ashmaroli.) This won't do anything in most cases (when `LOAD_GSL` isn't set). But when we set it (in our CI env), it will include GSL in our bundled gems so that we can actually test with GSL support in CI. See here for more info: jekyll#196 (comment)
mkasberg
commented
May 23, 2022
| @@ -54,9 +55,6 @@ jobs: | |||
| with: | |||
| ruby-version: ${{ matrix.ruby_version }} | |||
| bundler-cache: true | |||
| - name: Install GSL Gem | |||
There was a problem hiding this comment.
No longer necessary - bundle install will install this gem now.
|
You can tell that |
|
Thank you @mkasberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #196, I attempted to make the CI tests execute both with and without
GSL support because classifier-reborn is supposed to work in both cases
(though GSL increases performance). However, while doing so, I missed
the fact that
script/test(which our CI job runs) usesbundle execto run the tests. And when the tests are run with
bundle exec, Bundlerwill not load gems that aren't specified in the Gemfile. So our GSL
tests weren't actually using the GSL gem.
To fix this, we add
gem 'gsl' if ENV["LOAD_GSL"]to our Gemfile. (Thissolution was proposed by ashmaroli.) This won't do anything in most
cases (when
LOAD_GSLisn't set). But when we set it (in our CI env),it will include GSL in our bundled gems so that we can actually test
with GSL support in CI.
See here for more info:
#196 (comment)