Remove references to Madeline #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Using Madeleine, your application can persist the learned data over time. | ||
| # Later |
|
Yeah, Madeline is old and outdated. Maybe show both a file and Redis here? |
|
I agree with @parkr, and example would be a helpful change. |
|
? |
|
Woops, pressed close when I meant to press comment. I've updated this with a hopefully clearer explanation. |
|
LGTM! |
|
@Ch4s3 , are any more changes to this PR needed? |
|
Looks good. |
|
@Ch4s3, can you please add an item to the history file for this and reference this pr in your commit for that line? Thanks :) |
Ch4s3
added a commit
that referenced
this pull request
Feb 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like the example would be best using http://www.ruby-doc.org/core-2.2.0/Marshal.html not madeline.
No need to pull in extra dependencies when the standard library has got us covered, :).
Maybe using redis is a bad example and it should just write to a file?