Default hash cleanup #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kreynolds
referenced
this pull request
Sep 10, 2015
This mod makes it soe that you can train categories that have not been previously defined in the constructor.
| @@ -6,23 +6,26 @@ | |||
|
|
|||
| module ClassifierReborn | |||
| class Bayes | |||
| class CategoryNotFound < StandardError; end | |||
There was a problem hiding this comment.
Excellent! Please suffix this with Error or Exception.
What do you think about CategoryNotFoundError = Class.new(StandardError) to create them?
There was a problem hiding this comment.
I'll add Error. Is there a compelling reason to choose one exception definition over another?
|
I'll take a look this weekend 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few things got done here: