Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add site.github.public_repositories[].releases #224

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Add site.github.public_repositories[].releases #224

merged 1 commit into from
Apr 20, 2022

Conversation

parkr
Copy link
Member

@parkr parkr commented Apr 15, 2022

For each public repository rendered, we will also list releases for them.

Fixes #221.

@parkr parkr mentioned this pull request Apr 15, 2022
Closed
mattr-
mattr- reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the releases method will need to be whitelisted. This looks fine to me otherwise.

@parkr
Copy link
Member Author

parkr commented Apr 16, 2022

@mattr- It's already allowed: https://github.com/jekyll/github-metadata/blob/master/lib/jekyll-github-metadata/client.rb#L19

Pushed a fix for Rubocop.

@parkr
Add site.github.public_repositories[].releases
beaa00a 
For each public repository rendered, we will also list releases for them.
@parkr
Copy link
Member Author

parkr commented Apr 20, 2022

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit f3b27ce into main Apr 20, 2022
@jekyllbot jekyllbot deleted the releases branch April 20, 2022 06:15
@9bow 9bow mentioned this pull request Apr 29, 2022
Merged
@jekyll jekyll locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattr- mattr- mattr- left review comments

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

looks like there is no releases in the site.github.public_repositories
3 participants
@parkr @mattr- @jekyllbot