Remove trailing slash from html_url if present #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parkr how does this look to you? Looks like tests are failing because 2.0.1 was released, but not in the latest version of the Pages gem. I'm going to suggest we merge this here, cut 2.0.2, and bump the pages gem once with both, since 2.0.1 contains no in-production changes. |
|
LGTM. I need to figure out a better way to test against the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, the
html_urlfield of the pages preview API will begin returning URLs with trailing slashes in all cases. Because many sites hardcode things like{{ page.url | prepend: site.github.url }}, we need to maintain backwards compatibility, and havesite.github.urlcontinue to not have a trailing slash.This PR simply strips the trailing slash from the calculated URL or API response, if it's present, so that we never have a trailing slash. Ever.