Add rubocop #69
Merged
Add rubocop #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| block.call | ||
| yield |
There was a problem hiding this comment.
wont this be a problem? What happens to block here? Is yield supposed to know to call block? 😕
There was a problem hiding this comment.
That was Rubocop's doing, and tests pass?
There was a problem hiding this comment.
Yeah, it's just confusing 😜 I think yield doesn't care about the arity of the block so maybe just simplify this to
def save_from_errors(default = false)
yield @client
rescue # ...
# ...
end
|
Thank you! ❤️ a couple comments above if you wouldn't mind clarifying. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of Jekyll's Rubocop config.