Remove the path before setting site.url
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jekyll/gh-pages |
benbalter
reviewed
Oct 7, 2016
| def set_url_and_baseurl_fallbacks! | ||
| return unless Jekyll.env == "production" | ||
|
|
||
| parsed_url = URI(drop.url) |
There was a problem hiding this comment.
Rather than re-parsing the URL, can we re-use https://github.com/jekyll/github-metadata/blob/master/lib/jekyll-github-metadata/repository.rb#L150-L152?
|
@benbalter Updated! |
|
@jekyllbot: merge +bug |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benbalter Got a problem. Right now, if you have
https://benbalter.github.io/maps/assite.github.url, you get:baseurl = "/maps/"✅url = "https://benbalter.github.io/maps/"❌This means
minimais providing bad url's.