Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize date attribute of date-type archive pages #154

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Memoize date attribute of date-type archive pages #154

merged 1 commit into from
Mar 18, 2020

Conversation

ashmaroli
Copy link
Member

So that a new Date object is not created on every call

DirtyF
DirtyF approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, looks like memoizing the date attribute is ok :)

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 06fc093 into jekyll:master Mar 18, 2020
jekyllbot added a commit that referenced this pull request Mar 18, 2020
@jekyllbot
Update history to reflect merge of #154 [ci skip]
661ce7f
@ashmaroli ashmaroli deleted the memoize-archive-date branch March 18, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashmaroli @DirtyF @jekyllbot