Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add xml-stylesheet if provided #148

Closed
pathawks opened this issue Dec 24, 2016 · 5 comments · Fixed by #149
Closed

Only add xml-stylesheet if provided #148

pathawks opened this issue Dec 24, 2016 · 5 comments · Fixed by #149

Comments

@pathawks
Copy link
Member

jekyll-sitemap will only link to a stylesheet if one is provided; it does not provide its own default stylesheet.

I like this approach. I don't particularly care how my feed renders in a web browser, but if it is going to be skinned it seems like it should be skinned to fit the site. We should encourage themes to provide a stylesheet, but I don't know that we need to provide one by default.

jekyll/jekyll-sitemap#143

@benbalter
Copy link
Contributor

We should encourage themes to provide a stylesheet, but I don't know that we need to provide one by default.

👍 to this approach. FWIW, the existing stylesheet makes it hard to debug feed issues and compare unrendered feeds.

@ashmaroli
Copy link
Member

We should encourage themes to provide a stylesheet

Hi guys, say Minima is able to deploy a stylesheet (e.g. feed.xslt.xml) for this. How would a user be able to enable / disable it (if they do not want to use Jekyll Feed or generate feeds at all, the XSL file shouldn't exist in their _site)

@pathawks
Copy link
Member Author

@ashmaroli I understand where you are coming from, but I don't think it's a problem for themes to just always provide an XSLT by default.

If a user only uses certain social media icons, it's not like the other images are excluded from the generated site.

@ashmaroli
Copy link
Member

I see..
Would the presence of feed.xslt.xml affect a feed.xml generated without using jekyll-feed?

@pathawks
Copy link
Member Author

Only if that feed explicitly linked to the XSLT.

@jekyll jekyll locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants