-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add xml-stylesheet if provided #148
Comments
👍 to this approach. FWIW, the existing stylesheet makes it hard to debug feed issues and compare unrendered feeds. |
Hi guys, say Minima is able to deploy a stylesheet (e.g. |
@ashmaroli I understand where you are coming from, but I don't think it's a problem for themes to just always provide an XSLT by default. If a user only uses certain social media icons, it's not like the other images are excluded from the generated site. |
I see.. |
Only if that feed explicitly linked to the XSLT. |
jekyll-sitemap will only link to a stylesheet if one is provided; it does not provide its own default stylesheet.
I like this approach. I don't particularly care how my feed renders in a web browser, but if it is going to be skinned it seems like it should be skinned to fit the site. We should encourage themes to provide a stylesheet, but I don't know that we need to provide one by default.
jekyll/jekyll-sitemap#143
The text was updated successfully, but these errors were encountered: