Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the language code #15

Closed
XhmikosR opened this issue May 12, 2015 · 9 comments
Closed

Allow specifying the language code #15

XhmikosR opened this issue May 12, 2015 · 9 comments

Comments

@XhmikosR
Copy link
Contributor

By default, don't add anything, but give the user the ability to specify the language code.

@pathawks
Copy link
Member

Is there any prior art here?

Do any of the importers import any language information, either per post or per site?

Is there any existing convention for specifying this information?

@XhmikosR
Copy link
Contributor Author

Only the specs as far as I can tell. language is a per channel element.

@pathawks
Copy link
Member

But, because it XML, any element can have an xml:lang attribute.

@XhmikosR
Copy link
Contributor Author

That is true, but the specs don't mention anything about each element. So it should be a per channel sub-element.

@benbalter benbalter modified the milestone: Someday (TM) May 18, 2015
@pathawks
Copy link
Member

Is there any prior art here at all? Are there any i18n Jekyll plugins/workflows that set language information anywhere?

@parkr
Copy link
Member

parkr commented Dec 13, 2015

Are there any i18n Jekyll plugins/workflows that set language information anywhere?

@pathawks There are a number of i18n plugins for Jekyll out in the wild. Octopress's Multilingual is the only one whose development I have followed. https://github.com/octopress/multilingual

@pathawks
Copy link
Member

I don't see any language element in the Atom spec, but <feed> could have an xml:lang set to {{ site.lang }}, if present. Each <entry> could also have an xml:lang set to {{ post.lang }}. All links could also include hreflang if we can reasonably figure out the language of the resource the link points to.

Would this be reasonable/sufficient? Are there any great examples of feeds from multilingual sites that properly include language information to look to as an example?

@pathawks
Copy link
Member

This has been fixed by #75

@XhmikosR
Copy link
Contributor Author

Thanks! Any chance for a new release?

@jekyll jekyll locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants