Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about how i18n might work #75

Merged
merged 1 commit into from
Mar 19, 2016
Merged

Think about how i18n might work #75

merged 1 commit into from
Mar 19, 2016

Conversation

pathawks
Copy link
Member

This pull request represents an implementation of my proposal in #15 (comment)

Certainly, some tests need to be written before this is merged, but this is an effort to get the discussion going.

@parkr
Copy link
Member

parkr commented Dec 14, 2015

This seems reasonable to me, as it is congruent with the idea that the entire site is one language, or that a given post is one language. @benbalter, how do you feel? It seems like a small thing, but could make a number of folks happy.

@benbalter
Copy link
Contributor

👍. Is lang an established property? (versus language:?)

@pathawks
Copy link
Member Author

pathawks commented Jan 4, 2016

lang is used by octopress/multilingual

@benbalter
Copy link
Contributor

Makes sense.

@parkr
Copy link
Member

parkr commented Mar 19, 2016

:shipit:

@pathawks
Copy link
Member Author

@jekyllbot: merge

jekyllbot added a commit that referenced this pull request Mar 19, 2016
@jekyllbot jekyllbot merged commit 22dbc2f into jekyll:master Mar 19, 2016
jekyllbot added a commit that referenced this pull request Mar 19, 2016
@pathawks pathawks deleted the i18n branch March 19, 2016 20:36
@jekyll jekyll locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants