Use site.title for meta tag if available #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,14 @@ def url | |||
| config["github"]["url"] | |||
| end | |||
| end | |||
|
|
|||
| def title | |||
There was a problem hiding this comment.
Perhaps
def title
config["title"] || config["name"]
endThere was a problem hiding this comment.
I am trying to avoid output of title="" if neither is specified.
Am I overthinking this?
pathawks
force-pushed
the
pr/fallback-title
branch
from
afae66d
to
6888aa8
Compare
| %(href="#{url}/#{path}") | ||
| ] | ||
| if title | ||
| link_attributes << %(title="#{title}") |
There was a problem hiding this comment.
Is this too complicated for what I'm trying to accomplish?
There was a problem hiding this comment.
Not sure if it makes sense here, but here's what we did for Jekyll avatar to solve a similar problem.
pathawks
force-pushed
the
pr/fallback-title
branch
2 times, most recently
from
16fd64a
to
83aecf4
Compare
|
Oh hey 💯 |
pathawks
force-pushed
the
pr/fallback-title
branch
2 times, most recently
from
2bcacf9
to
25cbb59
Compare
|
I think this is a lot cleaner (even if slightly over-engineered). 👍 |
pathawks
force-pushed
the
pr/fallback-title
branch
from
1808306
to
3cac66c
Compare
|
@jekyllbot: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Mar 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use
site.title(if present) for the feed title when rendering the<link>tag. Ifsite.titleis undefined, it will fallback tosite.name.This mirrors the current behavior of the feed itself:
{% if site.title %} <title>{{ site.title | xml_escape }}</title> {% elsif site.name %} <title>{{ site.name | xml_escape }}</title> {% endif %}