Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute_url to generate the feed_meta url #150

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Use absolute_url to generate the feed_meta url #150

merged 1 commit into from
Dec 30, 2016

Conversation

benbalter
Copy link
Contributor

Rather than writing our own URL logic, lets just let Jekyll do the heavy lifting for us.

This should be a backwards compatible change.

pathawks
pathawks approved these changes Dec 30, 2016
View reviewed changes
Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, this will require Jekyll 3.3; we will have to drop older versions:+1:

@benbalter
Copy link
Contributor Author

@jekyllbot: merge +minor.

@jekyllbot jekyllbot merged commit 9325339 into master Dec 30, 2016
@jekyllbot jekyllbot deleted the use-absolute-url branch December 30, 2016 20:55
jekyllbot added a commit that referenced this pull request Dec 30, 2016
@jekyllbot
Update history to reflect merge of #150 [ci skip]
035cdd3
@jekyll jekyll locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benbalter @pathawks @jekyllbot