Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for older version of Jekyll #234

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Remove check for older version of Jekyll #234

merged 3 commits into from
Sep 6, 2018

Conversation

ashmaroli
Copy link
Member

Since the plugin requires ~> Jekyll 3.3, the check for whether site responds to in_source_dir (available since Jekyll-3.0) is unnecessary.

@DirtyF DirtyF requested a review from pathawks July 5, 2018 17:12
@pathawks
Copy link
Member

pathawks commented Jul 5, 2018

jekyll-feed/jekyll-feed.gemspec

Line 23 in bdd6f1b

spec.add_dependency "jekyll", "~> 3.3"

https://github.com/jekyll/jekyll/blob/v3.3.0/lib/jekyll/site.rb#L361-L371

👍

@DirtyF
Copy link
Member

DirtyF commented Sep 6, 2018

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit b5c5d7f into jekyll:master Sep 6, 2018
jekyllbot added a commit that referenced this pull request Sep 6, 2018
@jekyllbot
Update history to reflect merge of #234 [ci skip]
294b131
@ashmaroli ashmaroli deleted the remove-site-method-check branch September 7, 2018 18:02
@jekyllbot jekyllbot mentioned this pull request Sep 9, 2018
Merged
@jekyll jekyll locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashmaroli @pathawks @DirtyF @jekyllbot