Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update type in defaults #247

Merged
merged 1 commit into from Oct 23, 2018
Merged

test: update type in defaults #247

merged 1 commit into from Oct 23, 2018

Conversation

jekyllbot
Copy link
Contributor

@jekyllbot jekyllbot commented Oct 23, 2018 •
edited by DirtyF

Minor config deprecation

type is pages since Jekyll 3

@DirtyF
test: update type
29d071d 
type is pages since Jekyll 3
@DirtyF DirtyF changed the title test: update type type is pages since Jekyll 3 test: update type in defaults Oct 23, 2018
@DirtyF DirtyF added the tests label Oct 23, 2018
@DirtyF DirtyF requested a review from a team October 23, 2018 12:54
ashmaroli
ashmaroli approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch

@DirtyF DirtyF merged commit e250bdb into master Oct 23, 2018
@DirtyF DirtyF deleted the pull/fix-defaults branch October 23, 2018 13:15
@jekyll jekyll locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jekyllbot @ashmaroli @DirtyF