Add xml:base attribute to the feed tag #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might need to add it per post, if a post contains relative links. |
Done via d863e8a. Good call. |
| @@ -33,7 +33,9 @@ | |||
| <updated>{{ post.date | date_to_xmlschema }}</updated> | |||
|
|
|||
| <id>{{ post.id | prepend: url_base | xml_escape }}</id> | |||
| <content type="html">{{ post.content | markdownify | xml_escape }}</content> | |||
| <content type="html" xml:base="{{ url_base | xml_escape }}"> | |||
There was a problem hiding this comment.
I think it should be post.url rather than just url_base, since that is what links would be relative to.
There was a problem hiding this comment.
Once again, you're absolutely right.
|
👍 |
benbalter
added a commit
that referenced
this pull request
May 21, 2015
Add xml:base attribute to the feed tag
|
🎉 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @pathawks over in #36 (comment), and per the Atom spec:
I believe this fixes #22.
/cc @holman and @bkeepers, as this should finally fix the question that started this all