Add failing excerpt tests #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benbalter For the "author detail" post, the excerpt is created automatically. That tells me why Sorry for not writing a test for that one. Total noob move. :/ |
it seems `blank` is part of a rails integration, as `#blank?` is part of ActiveSupport (or similar) and not a part of Ruby itself.
|
Nice. Thanks. Will get this (selfishly) deployed. |
|
Side effect of dogfooding: selfish is good for all. |
|
Good news: This feature now has tests. Bad news: I'm an idiot. |
Oh no! I didn't even think to check. Well, now are you using jekyll-feed?!?! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parkr a failing test to check #57, feel free to hijack this branch/pr if you'd like. Not sure what's going on.