Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not let jekyll-last-modified-at break tests #87

Merged
merged 1 commit into from
Jan 23, 2016
Merged

Conversation

pathawks
Copy link
Member

I don't know why #86 is failing tests on Travis, but I cannot reproduce locally.

Frankly, I don't much care if jekyll-last-modified-at is coming up with the correct date or not, so long as we are using what is provided in the last_modified_at property.

This removes the dev dependency on jekyll-last-modified-at and, hopefully, will make the tests a little less rickety…?

@benbalter
Copy link
Contributor

Makes sense. Think we can assume the plugin has its own tests, and just use its documented API.

@pathawks pathawks merged commit 4f11ef7 into master Jan 23, 2016
pathawks added a commit that referenced this pull request Jan 23, 2016
@pathawks pathawks deleted the last-modified branch January 23, 2016 18:16
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants