Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test against Jekyll 3 #99

Merged
merged 1 commit into from
Mar 19, 2016
Merged

Only test against Jekyll 3 #99

merged 1 commit into from
Mar 19, 2016

Conversation

pathawks
Copy link
Member

@pathawks pathawks commented Mar 3, 2016

This reduces the number of CI test environments from 7 to 1.

Since most of the business of this plugin is implemented in Liquid, hopefully we're not doing anything that might break in one version of Ruby and not another.

This also drops tests against Jekyll 2.x

I have not removed Jekyll 2.x from the .gemspec, I have only removed the tests.

@benbalter
Copy link
Contributor

Should we update the Gemspec to require Jekyll > 3?

@pathawks
Copy link
Member Author

pathawks commented Mar 5, 2016

Should we update the Gemspec to require Jekyll > 3?

I thought about that.

Since we have nothing to immediately gain by dropping support for 2.x, maybe we could hold off on this until GitHub Pages supports 3.1. At that time, we could drop support for anything less than 3.1 and take advantage of the smartify filter?

@benbalter
Copy link
Contributor

Since we have nothing to immediately gain by dropping support for 2.x, maybe we could hold off on this until GitHub Pages supports 3.1. At that time, we could drop support for anything less than 3.1 and take advantage of the smartify filter?

Makes sense.

@parkr
Copy link
Member

parkr commented Mar 10, 2016

@pathawks feel free to merge. you should be able to use jekyllbot too! If you want categories for the changelog, it understands:

  • +dev – Development Fixes
  • +bug – Bug Fixes
  • +major – Major Enhancements
  • +minor – Minor Enhancements
  • +site – Site Enhancements

you can leave off the category to just add under the version. it uses the PR title so fix that too if you want to before you ask jekyllbot to merge. 😄

@parkr
Copy link
Member

parkr commented Mar 19, 2016

@jekyllbot: merge

jekyllbot added a commit that referenced this pull request Mar 19, 2016
@jekyllbot jekyllbot merged commit 2b1457f into master Mar 19, 2016
@jekyllbot jekyllbot deleted the pr/matrix branch March 19, 2016 20:27
jekyllbot added a commit that referenced this pull request Mar 19, 2016
@jekyll jekyll locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants