Tumblr Migrator dies on audio posts

[mitchellhislop]

Hello,

First - I am not a ruby guy, but I know enough to dig into pure ruby code.

I was trying to run the migrator, and it kept dying with:

/usr/lib/ruby/gems/1.8/gems/jekyll-0.11.2/lib/jekyll/migrators/tumblr.rb:72:in post_to_hash': undefined method 'at' for #Hash:0x7f56c4d622f8 (NoMethodError)
from /usr/lib/ruby/gems/1.8/gems/jekyll-0.11.2/lib/jekyll/migrators/tumblr.rb:27:in process'
from /usr/lib/ruby/gems/1.8/gems/jekyll-0.11.2/lib/jekyll/migrators/tumblr.rb:27:in map'
from /usr/lib/ruby/gems/1.8/gems/jekyll-0.11.2/lib/jekyll/migrators/tumblr.rb:27:in `process'
from -e:1

I dug into that line, dumped some vars, and figured out that it looks like the at function (due to a change in structure) was not there, but removing it worked fine:

when "audio"
          if !post["id3-title"].nil?
            title = post["id3-title"]
            content = post["audio-player"] + "<br/>" + post["audio-caption"]
          else
            title = post["audio-caption"]
            content = post["audio-player"]
          end

Sorry I can't contribute a pull request - I dont know near enough about gems or testing them.

[kfatehi]

Hey I ran across the same thing. (Hash#at ???)
I ended up with this script for a successful import without modifying the gem.

Using jekyll-import 0.1.0.beta1

require 'rubygems'

## 
# Monkeypatch to fix the following
# tumblr.rb:73
#   content = post.at["audio-player"] + "<br/>" + post["audio-caption"]
class Hash
  def at
    self
  end
end

begin
  require 'jekyll/jekyll-import/tumblr'
rescue
  puts "Missing jekyll-import gem. Do this: gem install jekyll-import --pre"
  exit -1
end

JekyllImport::Tumblr.process("http://slog.keyvanfatehi.com", true)

[mitchellhislop]

Yeah, I'm thinking that is the same thing, and that is far more elegant than my solution was.

Good ol' monkeypatches.

[parkr]

If any of you want to submit a PR to fix this, that would be splendid :)

[parkr]

Both @mattr- and I are attentive to issues and PRs here :)

[mitchellhislop]

Ill see if I can learn enough Ruby to do just that - sounds like a fun challenge.

[parkr]

Why do we use Hash#at anyway?