New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic image retrieval, cmdargs does not work #134
Conversation
The command-line args will work once 2.0 drops, but sadly it's been mucked up because Jekyll 1.x uses Commander which uses symbol keys, but Jekyll 2.x uses Mercenary which uses string keys so it's a whole thing. This looks pretty good! It'd be baller if you could separate this stuff out into a separate method so we can unit test it, then... you guessed it: add a quick test for it! Thank you! |
I did my best, though review this patch with grain of salt as I do not know Ruby at all (Yes, I've lost my Ruby virginity for this patch). Note: I forgot to mention that this patch also REPLACES any class in PRE elements to "prettyprint". These settings worked the best for me but side affects must be considered. |
end | ||
|
||
(content/"pre").each do |pre| | ||
pre["class"] = 'prettyprint' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do this?
To pretty print code snippets (duh!). This may probably better be handled in some other stage -- i.e. when generating the actual HTML pages. Feel free to remove it if there's a better way to handle syntax highlighting. |
This patch:
Bugs:
Command line arguments does not work.