New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for S9Y import #18

Merged
merged 1 commit into from Mar 24, 2013

Conversation

Projects
None yet
3 participants
@boone
Contributor

boone commented Mar 24, 2013

I tried to use the S9Y import as-is and got the following error: error: can't convert Hash into String

It seems the file name wasn't being passed in as the code was expecting. I modeled a fix after the RSS import, to use the --source argument. That will also allow flexibility to add an option to import comments.

@@ -12,11 +12,21 @@
module JekyllImport
module S9Y
def self.process(file_name)
def self.validate(options)
if !options[:source]

This comment has been minimized.

@parkr

parkr Mar 24, 2013

Member

Not a fan of unless?

@parkr

parkr Mar 24, 2013

Member

Not a fan of unless?

This comment has been minimized.

@boone

boone Mar 24, 2013

Contributor

I copied that code straight out of rss.rb. unless is fine with me.

@boone

boone Mar 24, 2013

Contributor

I copied that code straight out of rss.rb. unless is fine with me.

This comment has been minimized.

@parkr

parkr Mar 24, 2013

Member

Ah! Ok, cool.

@parkr

parkr Mar 24, 2013

Member

Ah! Ok, cool.

parkr added a commit that referenced this pull request Mar 24, 2013

Merge pull request #18 from boone/fix_s9y_process
Fix for S9Y import

Specify data source using --source option. Solves "can't convert Hash into String" error

@parkr parkr merged commit c44fa97 into jekyll:master Mar 24, 2013

1 check failed

default The Travis build failed
Details

parkr added a commit that referenced this pull request Mar 24, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.