Fix for S9Y import #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into String" issue.
| @@ -12,11 +12,21 @@ | |||
|
|
|||
| module JekyllImport | |||
| module S9Y | |||
| def self.process(file_name) | |||
| def self.validate(options) | |||
| if !options[:source] | |||
There was a problem hiding this comment.
I copied that code straight out of rss.rb. unless is fine with me.
parkr
added a commit
that referenced
this pull request
Mar 24, 2013
Fix for S9Y import Specify data source using --source option. Solves "can't convert Hash into String" error
parkr
added a commit
that referenced
this pull request
Mar 24, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the S9Y import as-is and got the following error:
error: can't convert Hash into StringIt seems the file name wasn't being passed in as the code was expecting. I modeled a fix after the RSS import, to use the
--sourceargument. That will also allow flexibility to add an option to import comments.