New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author and nid field to import from Drupal 7. #237

Merged
merged 1 commit into from Jan 6, 2016

Conversation

Projects
None yet
3 participants
@geerlingguy
Contributor

geerlingguy commented Jan 6, 2016

With the current Drupal 7 import script, there is no author data (very helpful when there are multi-author blogs, which is often the case with Drupal sites) nor nid attached to the imported posts. The nid can be extremely helpful in cases where you use a customized template to show Disqus comments or need to print other legacy-powered data on particular posts.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 6, 2016

Member

Wonderful! One nit above, then I'll merge 👍

Member

parkr commented Jan 6, 2016

Wonderful! One nit above, then I'll merge 👍

@geerlingguy

This comment has been minimized.

Show comment
Hide comment
@geerlingguy

geerlingguy Jan 6, 2016

Contributor

@parkr - Sorry about that, it's fixed now!

Contributor

geerlingguy commented Jan 6, 2016

@parkr - Sorry about that, it's fixed now!

parkr added a commit that referenced this pull request Jan 6, 2016

@parkr parkr merged commit 9afec94 into jekyll:master Jan 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 6, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 6, 2016

Member

Can this be backported to Drupal 6?

Thanks for your contributions!! 🎉

Member

parkr commented Jan 6, 2016

Can this be backported to Drupal 6?

Thanks for your contributions!! 🎉

@geerlingguy

This comment has been minimized.

Show comment
Hide comment
@geerlingguy

geerlingguy Jan 6, 2016

Contributor

@parkr - The structure of the users table and uid/name fields is exactly the same between D6/D7... however, the field_data_body table and it's relationship to the node table isn't the same, so these particular changes could be backported, but the exact commit couldn't be cherry-picked into the drupal6 file/backported without rejiggering a little.

Unfortunately, I don't have any Drupal 6 sites I can use to test it, otherwise I'd do that really quick and backport it myself :/

Contributor

geerlingguy commented Jan 6, 2016

@parkr - The structure of the users table and uid/name fields is exactly the same between D6/D7... however, the field_data_body table and it's relationship to the node table isn't the same, so these particular changes could be backported, but the exact commit couldn't be cherry-picked into the drupal6 file/backported without rejiggering a little.

Unfortunately, I don't have any Drupal 6 sites I can use to test it, otherwise I'd do that really quick and backport it myself :/

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.