New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordpressdotcom.rb to use its method parameter correctly. #24

Merged
merged 2 commits into from May 15, 2013

Conversation

Projects
None yet
4 participants
@stevenbedrick
Contributor

stevenbedrick commented May 14, 2013

When invoked from the command line using jekyll import wordpressdotcom -s $FILENAME, the filename argument being passed in to WordpressDotCom::process() is not a simple string. It is instead a Hash, and as such the method's dying on line 15. This patch fixes the error.

Update wordpressdotcom.rb
When invoked from the command line using `jekyll import wordpressdotcom -s $FILENAME`, the `filename` argument being passed in to WordpressDotCom::process() is not a simple string. It is instead a Hash, and as such the method's dying on line 15. This patch fixes the error.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 14, 2013

Member

Please update the fallback in the method definition, too!

Member

parkr commented May 14, 2013

Please update the fallback in the method definition, too!

Fixed fall-through behavior in method definition.
My previous commit fixed a bug in how the method handles the `filename` argument, but introduced a new one in that I hadn't updated the method's default `filename` value to _also_ be a hash. This commit fixes that.
@stevenbedrick

This comment has been minimized.

Show comment
Hide comment
@stevenbedrick

stevenbedrick May 14, 2013

Contributor

Good catch, thanks for pointing it out. I think I've got it this time.

Contributor

stevenbedrick commented May 14, 2013

Good catch, thanks for pointing it out. I think I've got it this time.

@RickEyre

This comment has been minimized.

Show comment
Hide comment

Fixes #23

parkr added a commit that referenced this pull request May 15, 2013

Merge pull request #24 from stevenbedrick/patch-1
Update wordpressdotcom.rb to use its method parameter correctly.

@parkr parkr merged commit 51aea72 into jekyll:master May 15, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 15, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.