Tumblr improvements #27
Conversation
|
This is great! It looks like some of your changes broke the tests we have in place. Would you mind updating those to comply with your changes? : ) |
| end | ||
|
|
||
| end until blog["posts"].size < per_page |
There was a problem hiding this comment.
This is nifty – I have never seen this post-until syntax before. 👍
There was a problem hiding this comment.
That was actually in the original code, I just changed the indent here.
Post-until/post-while blocks are pretty awesome for those cases (like this one), where you know you always want to run at least once, and then conditionally re-run in a loop after that initial cycle.
|
I wasn't sure about the tests, I honestly didn't even look at them yet. I got the base stuff working for myself, and wanted to get the PR open so I could start making this whole importer better. I noticed there seems to be some command line tools for running these scripts, but everyone looks like they just tell people to call |
|
I think we'd like to transition folks to the command line tools. The documentation just tells people to call |
|
Is there a specific invocation for the command line tools? I skimmed the files a bit but didn't see one. Seems like something that should be the very first thing in the README. |
|
@tekkub It plugins into But from here, you can probably run >> Jekyll::Commands::Import.process(migrator_name, options) |
|
@tekkub if you'd prefer i merge and make the modifications I mentioned, 👍. can take a load off your already-full back |
|
If you want to do that, it's cool with me. I've left this sitting in my inbox for when I can find time to attack it again, but I'm in SF for work this week. |
|
I'm going to take care of this now. :) |
|
I've had this tab open for a month – and finally got to fixing the test suite so I could merge. Yay! Thanks again for the fixes, @tekkub. 🍖 🤘 |
While importing my tumblr, I ran into a number of reblogged posts that had bad photos in them. This PR includes fixes to retry smaller photos if one fails. I also made the importer a bit more verbose so I could keep track of it working. For folks with lots of photos in their blogs, I made sure that those photos already saved locally are not re-downloaded, making the importer run a lot faster on re-runs.