New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native Ruby libs to convert HTML to text - Issue #32 #33

Merged
merged 1 commit into from Jul 2, 2013

Conversation

Projects
None yet
4 participants
@georgeanderson
Contributor

georgeanderson commented Jun 28, 2013

Attempt to close Issue #32

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 30, 2013

Member

This looks OK to me. Should it be XML, though, so it can convert all XML documents as well?

@mattr-, what do you think?

Member

parkr commented Jun 30, 2013

This looks OK to me. Should it be XML, though, so it can convert all XML documents as well?

@mattr-, what do you think?

mattr- added a commit that referenced this pull request Jul 2, 2013

Merge pull request #33 from georgeanderson/master
Use native Ruby libs to convert HTML to text - Issue #32

@mattr- mattr- merged commit 03e95a0 into jekyll:master Jul 2, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jul 2, 2013

Member

Looks good to me. I went ahead and merged it. I don't think anything on Tumblr deals with XML so using the HTML parser should be fine.

Member

mattr- commented Jul 2, 2013

Looks good to me. I went ahead and merged it. I don't think anything on Tumblr deals with XML so using the HTML parser should be fine.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 2, 2013

Member

Cool! Thanks :)

Member

parkr commented Jul 2, 2013

Cool! Thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.