Bump dependencies and CI Ruby versions #493
Conversation
The last release was in 2018 and in turn has outdated runtime dependencies
|
Looks like we have reached a stalemate.. :-( |
|
Maybe we need to make this about dropping EOL Rubies and make a separate CL about adding Ruby 3 support. What do you think? |
|
Another thing to consider is limiting old importers to a specific ruby version. We can add runtime checks and documentation to say a given importer is limited to Ruby 2.x. It’s not ideal but this gem and its importers are best-effort. |
ashmaroli
changed the title
| s.add_development_dependency("simplecov", "~> 0.7") | ||
| s.add_development_dependency("simplecov-gem-adapter", "~> 1.0") | ||
|
|
||
| # migrator dependencies: | ||
| s.add_development_dependency("behance", "~> 0.3") | ||
| # s.add_development_dependency("behance", "~> 0.3") # uses outdated dependencies |
There was a problem hiding this comment.
Shall we move this to the Gemfile and add a Ruby version check or just wait until someone comes around and tries to add tests for the Behance importer?
There was a problem hiding this comment.
We shall wait for someone to add tests for the Behance importer or at minimum report a bug or some other issue with the Behance importer..
I'm not keen on moving dev_deps to Gemfile (for this project) because the Rubygems dev_deps listing may serve as secondary documentation for users.
There was a problem hiding this comment.
Ok. Commenting this out removes it from the dev deps anyway, so I'm not sure it's of much use here.
test/helper.rb
Outdated
| @@ -17,7 +17,7 @@ class Test::Unit::AssertionFailedError < ActiveSupport::TestCase::Assertion | |||
| require File.expand_path("../lib/jekyll-import.rb", __dir__) | |||
| include JekyllImport | |||
|
|
|||
| JekyllImport::Importer.subclasses.each(&:require_deps) | |||
| # JekyllImport::Importer.subclasses.each(&:require_deps) | |||
|
@jekyllbot: merge +dev |
Closes #492
Closes #494