Build and deploy docs site via GitHub Actions #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
approved these changes
Nov 30, 2022
| run: | | ||
| SOURCE_COMMIT="$(git log -1 --pretty="%an: %B" "$GITHUB_SHA")" | ||
| pushd docs/_site &>/dev/null | ||
| : > .nojekyll |
There was a problem hiding this comment.
Why not use "touch" here? This command is a bit obtuse.
There was a problem hiding this comment.
touch <file> and : > <file> is subtly different even though they appear to do the same at first glance.
touch <file> creates <file> if it doesn't exist and just modifies last accessed time atime on subsequent uses.
: > <file> also creates <file> if it doesn't exist but will truncate its length to 0 (changes mtime) on subsequent uses.
Ref: Stack Exchange Thread.
For argument's sake, one could state that in the current context, the maintainers have total control over .nojekyll never being a non-empty file and that its contents are irrelevant regardless.
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Dec 2, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
Ashwin Maroli: Build and deploy docs site via GitHub Actions (#500) Merge pull request 500
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how the docs are deployed for the Jekyll Core repository.
Rationale