New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Import jrnl files #51

Merged
merged 17 commits into from Oct 3, 2013

Conversation

Projects
None yet
4 participants
@aniketpant
Contributor

aniketpant commented Aug 12, 2013

New feature added for importing jrnl files.

$ jekyll import jrnl

Available overrides

  • --file: Path to input file (default: ~/journal.txt)
  • --time_format: the time format used by jrnl (default: %Y-%m-%d %H:%M)
  • --extension: file extension of the output file (default: md)
  • --layout: set layout of the output file (default: post)

Usage

# will use ~/path/to/file/work.txt as the jrnl file
$ jekyll import jrnl --file ~/path/to/file/work.txt

# will output all files as txt files
# this feature is yet to be implemented due to contraints from jekyll
$ jekyll import jrnl --extension txt

# will output all files with YAML data having layout: custom
# this feature is yet to be implemented due to contraints from jekyll
$ jekyll import jrnl --layout custom

aniketpant added some commits Aug 9, 2013

Start writing new feature for jrnl import
Signed-off-by: Aniket Pant <me@aniketpant.com>
Add new import feature for jrnl files
Signed-off-by: Aniket Pant <me@aniketpant.com>
@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Aug 12, 2013

Contributor

@parkr I didn't realize that overrides wouldn't work straight away. How do I allow the usage of --time_format, --extension and --layout?

Contributor

aniketpant commented Aug 12, 2013

@parkr I didn't realize that overrides wouldn't work straight away. How do I allow the usage of --time_format, --extension and --layout?

Add error if file not found
Signed-off-by: Aniket Pant <me@aniketpant.com>
extension = options[:extension] || "md"
layout = options[:layout] || "post"
date_length = Time.now().strftime(time_format).length

This comment has been minimized.

@parkr

parkr Aug 12, 2013

Member

Unlike Python, you don't need the parentheses here for Time.now(). You can just call Time.now.strftime #... :)

@parkr

parkr Aug 12, 2013

Member

Unlike Python, you don't need the parentheses here for Time.now(). You can just call Time.now.strftime #... :)

This comment has been minimized.

@aniketpant

aniketpant Aug 12, 2013

Contributor

@parkr Is the change required due to coding guidelines?

@aniketpant

aniketpant Aug 12, 2013

Contributor

@parkr Is the change required due to coding guidelines?

This comment has been minimized.

@parkr

parkr Sep 24, 2013

Member

Yes :)

Omit the parentheses when the method doesn't accept any arguments.

GitHub Ruby Styleguide

I'll add it to the CONTRIBUTING file if it isn't already there.

@parkr

parkr Sep 24, 2013

Member

Yes :)

Omit the parentheses when the method doesn't accept any arguments.

GitHub Ruby Styleguide

I'll add it to the CONTRIBUTING file if it isn't already there.

@parkr

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
date_length = Time.now().strftime(time_format).length
abort "'#{file}' not found." unless File.file?(file)

This comment has been minimized.

@parkr

parkr Aug 12, 2013

Member

It'd be great if this abort message described what wasn't found, namely the journal file.

@parkr

parkr Aug 12, 2013

Member

It'd be great if this abort message described what wasn't found, namely the journal file.

@parkr

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
entries = input.split("\n\n");
entries.each do |entry|
content = entry.split("\n")

This comment has been minimized.

@parkr

parkr Aug 12, 2013

Member

In a vanilla install of jrnl, everything was in the same line, separated by \n\n. Is that the title then?

@parkr

parkr Aug 12, 2013

Member

In a vanilla install of jrnl, everything was in the same line, separated by \n\n. Is that the title then?

This comment has been minimized.

@aniketpant

aniketpant Aug 12, 2013

Contributor

jrnl creates entries in the following format:

Timestamp Title
Entry content

input.split("\n\n") splits all entries and entry.split("\n") segregates the content from the meta.

@aniketpant

aniketpant Aug 12, 2013

Contributor

jrnl creates entries in the following format:

Timestamp Title
Entry content

input.split("\n\n") splits all entries and entry.split("\n") segregates the content from the meta.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 12, 2013

Member

Nice work! Looks great so far. One suggestion I would make is to encapsulate various functionality into methods and call them from the main method. :)

Member

parkr commented Aug 12, 2013

Nice work! Looks great so far. One suggestion I would make is to encapsulate various functionality into methods and call them from the main method. :)

@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Aug 12, 2013

Contributor

@parkr I am not clear with what you mean by that or maybe I didn't understand. Can you elaborate on which functionalities you want to be called form the main method?

Also, I had asked this question before, you might have missed it:

@parkr I didn't realize that overrides wouldn't work straight away. How do I allow the usage of --time_format, --extension and --layout?

Thanks :)

Contributor

aniketpant commented Aug 12, 2013

@parkr I am not clear with what you mean by that or maybe I didn't understand. Can you elaborate on which functionalities you want to be called form the main method?

Also, I had asked this question before, you might have missed it:

@parkr I didn't realize that overrides wouldn't work straight away. How do I allow the usage of --time_format, --extension and --layout?

Thanks :)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 12, 2013

Member

I just mean that the various logic it'd be cool if you split out into separate methods so the whole process wasn't one big method with all the nuts-and-bolts code packed into it.

At the moment, all options have to be added to the main Jekyll gem in bin/jekyll.

Member

parkr commented Aug 12, 2013

I just mean that the various logic it'd be cool if you split out into separate methods so the whole process wasn't one big method with all the nuts-and-bolts code packed into it.

At the moment, all options have to be added to the main Jekyll gem in bin/jekyll.

@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Aug 12, 2013

Contributor

I just mean that the various logic it'd be cool if you split out into separate methods so the whole process wasn't one big method with all the nuts-and-bolts code packed into it.

Ah. I was planning to do that at the start but then I saw that the other migrators were also written as a single block of code. It's always good to decouple code.

At the moment, all options have to be added to the main Jekyll gem in bin/jekyll.

I noticed that there is not provision for the addition of new overrides via CLI because there are only six of them available and they are hard coded. This gives me the idea to improve that code and allow the use of new overrides. Will try working on something. For now I will let the configuration I have provided in lines 17-19 (defaults are meaningful, they won't disturb anything). Once new overrides can be created, users will have more control over the imports.

Contributor

aniketpant commented Aug 12, 2013

I just mean that the various logic it'd be cool if you split out into separate methods so the whole process wasn't one big method with all the nuts-and-bolts code packed into it.

Ah. I was planning to do that at the start but then I saw that the other migrators were also written as a single block of code. It's always good to decouple code.

At the moment, all options have to be added to the main Jekyll gem in bin/jekyll.

I noticed that there is not provision for the addition of new overrides via CLI because there are only six of them available and they are hard coded. This gives me the idea to improve that code and allow the use of new overrides. Will try working on something. For now I will let the configuration I have provided in lines 17-19 (defaults are meaningful, they won't disturb anything). Once new overrides can be created, users will have more control over the imports.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 12, 2013

Member

Sorry for not being clear enough before! Thanks for being patient with me. :)

This gives me the idea to improve that code and allow the use of new overrides. Will try working on something.

Check out the commando branch on both repos - @mojombo was working on something similar a couple months a go - would you mind starting there? It allows each migrator to specify its own options, which is probably the solution we most want here. What do you think?

Member

parkr commented Aug 12, 2013

Sorry for not being clear enough before! Thanks for being patient with me. :)

This gives me the idea to improve that code and allow the use of new overrides. Will try working on something.

Check out the commando branch on both repos - @mojombo was working on something similar a couple months a go - would you mind starting there? It allows each migrator to specify its own options, which is probably the solution we most want here. What do you think?

@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Aug 12, 2013

Contributor

commando looks brute. I am going to start digging in the code. Can you update me on the work that has been going on it? (maybe mail or if any discussion is already going on the same)

Contributor

aniketpant commented Aug 12, 2013

commando looks brute. I am going to start digging in the code. Can you update me on the work that has been going on it? (maybe mail or if any discussion is already going on the same)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 12, 2013

Member

I unfortunately don't know much about what Tom was working on on that branch. I looked through it briefly once but wasn't sure where I needed to go from there. I'll rebase and look through it now :)

Member

parkr commented Aug 12, 2013

I unfortunately don't know much about what Tom was working on on that branch. I looked through it briefly once but wasn't sure where I needed to go from there. I'll rebase and look through it now :)

aniketpant added some commits Aug 13, 2013

Improve error message
Signed-off-by: Aniket Pant <me@aniketpant.com>
Decouple code and add docs
Signed-off-by: Aniket Pant <me@aniketpant.com>
Fix relative path issue
Signed-off-by: Aniket Pant <me@aniketpant.com>
@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 23, 2013

Contributor

@parkr About time we merged this?

Contributor

aniketpant commented Sep 23, 2013

@parkr About time we merged this?

@parkr

View changes

Show outdated Hide outdated jekyll-import.gemspec
@@ -6,7 +6,7 @@ Gem::Specification.new do |s|
s.name = 'jekyll-import'
s.version = '0.1.0.beta3'
s.date = '2013-07-14'
s.date = '2013-08-12'

This comment has been minimized.

@parkr

parkr Sep 23, 2013

Member

Would you mind reverting this change?

@parkr

parkr Sep 23, 2013

Member

Would you mind reverting this change?

@parkr

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
# convert relative to absolute if needed
file = File.expand_path(file)
abort "The jrnl file was not found. Please make sure '#{file}' exists." unless File.file?(file)

This comment has been minimized.

@parkr

parkr Sep 23, 2013

Member

What about adding something like, "If you would like to specify a different file, use the --file switch when executing this command."

@parkr

parkr Sep 23, 2013

Member

What about adding something like, "If you would like to specify a different file, use the --file switch when executing this command."

@parkr

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
def self.write_file(filename, meta, body)
File.open("_posts/#{filename}", "w") do |f|
f.puts meta
f.puts "---"

This comment has been minimized.

@parkr

parkr Sep 23, 2013

Member

It's customary to add a second newline after the terminating --- in the front-matter:

---
layout: blah
---

Start of my text...
@parkr

parkr Sep 23, 2013

Member

It's customary to add a second newline after the terminating --- in the front-matter:

---
layout: blah
---

Start of my text...
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 23, 2013

Member

Yes, I agree! Thanks for pinging.

Member

parkr commented Sep 23, 2013

Yes, I agree! Thanks for pinging.

aniketpant added some commits Sep 24, 2013

Revert date change and remove stray whitespace
Signed-off-by: Aniket Pant <me@aniketpant.com>
Improve error message
Signed-off-by: Aniket Pant <me@aniketpant.com>
Add newline for YAML front data
Signed-off-by: Aniket Pant <me@aniketpant.com>
@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 24, 2013

Contributor

@parkr Done.

Contributor

aniketpant commented Sep 24, 2013

@parkr Done.

# convert relative to absolute if needed
file = File.expand_path(file)
abort "The jrnl file was not found. Please make sure '#{file}' exists. You can specify a different file using the --file switch." unless File.file?(file)

This comment has been minimized.

@parkr

parkr Sep 24, 2013

Member

Just thinking about this again: does the --file switch actually work in your tests?

@parkr

parkr Sep 24, 2013

Member

Just thinking about this again: does the --file switch actually work in your tests?

This comment has been minimized.

@aniketpant

aniketpant Sep 24, 2013

Contributor

The --file switch works. I am using ~/journal.txt as the default because that's a jrnl default too. And then on L26, I check for the availability of the file.

@aniketpant

aniketpant Sep 24, 2013

Contributor

The --file switch works. I am using ~/journal.txt as the default because that's a jrnl default too. And then on L26, I check for the availability of the file.

This comment has been minimized.

@parkr

parkr Sep 24, 2013

Member

Awesome! I just wanted to make sure --file works.

@parkr

parkr Sep 24, 2013

Member

Awesome! I just wanted to make sure --file works.

@parkr

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
data = {
'layout' => layout.to_s,
'title' => title.to_s,
'date' => date.strftime("%Y-%m-%d %H:%M").to_s

This comment has been minimized.

@parkr

parkr Sep 24, 2013

Member

It'd be fantastic to add the system timezone here if this isn't UTC.

@parkr

parkr Sep 24, 2013

Member

It'd be fantastic to add the system timezone here if this isn't UTC.

@parkr

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
slug = title.downcase.strip.gsub(' ', '-').gsub(/[^\w-]/, '')
# generate filename
filename = date.strftime("%Y-%m-%d").to_s + "-#{slug}.#{extension}"

This comment has been minimized.

@parkr

parkr Sep 24, 2013

Member

This is a strange mixture of concatenation and interpolation. Would you please just use interpolation?

Prefer string interpolation instead of string concatenation

GitHub Ruby Styleguide, under "Strings"

@parkr

parkr Sep 24, 2013

Member

This is a strange mixture of concatenation and interpolation. Would you please just use interpolation?

Prefer string interpolation instead of string concatenation

GitHub Ruby Styleguide, under "Strings"

@parkr

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
body = content[1]
# strip timestamp from the dateline
date = Time.parse(content[0, date_length-1].to_s)

This comment has been minimized.

@parkr

parkr Sep 24, 2013

Member

This is already a string, no need to change it again ;)

@parkr

parkr Sep 24, 2013

Member

This is already a string, no need to change it again ;)

This comment has been minimized.

@aniketpant

aniketpant Sep 24, 2013

Contributor

Have to change. Otherwise, I get

no implicit conversion of Array into String (TypeError)
@aniketpant

aniketpant Sep 24, 2013

Contributor

Have to change. Otherwise, I get

no implicit conversion of Array into String (TypeError)

This comment has been minimized.

@parkr

parkr Sep 24, 2013

Member

Ah ok

@parkr

parkr Sep 24, 2013

Member

Ah ok

@parkr

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
date = Time.parse(content[0, date_length-1].to_s)
# strip title from the dateline
title = dateline[date_length+1, dateline.length]

This comment has been minimized.

@parkr

parkr Sep 24, 2013

Member

Please add spaces between the date_length, +, and 1 as you would for methods:

Use spaces around the = operator when assigning default values to method parameters

@parkr

parkr Sep 24, 2013

Member

Please add spaces between the date_length, +, and 1 as you would for methods:

Use spaces around the = operator when assigning default values to method parameters

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2013

Member

Great job so far! Just a few Python vs. Ruby stuff but other than that it's 👍 !!

Member

parkr commented Sep 24, 2013

Great job so far! Just a few Python vs. Ruby stuff but other than that it's 👍 !!

aniketpant added some commits Sep 24, 2013

Conform code to Ruby Styleguide
Signed-off-by: Aniket Pant <me@aniketpant.com>
Add timezone to date
Signed-off-by: Aniket Pant <me@aniketpant.com>
@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 24, 2013

Contributor

I am neither Python nor Ruby. I am PHP.

Contributor

aniketpant commented Sep 24, 2013

I am neither Python nor Ruby. I am PHP.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2013

Member

One more comment above then we should be good to go.

Want to try your hand at tests, or want us to do that?

Member

parkr commented Sep 24, 2013

One more comment above then we should be good to go.

Want to try your hand at tests, or want us to do that?

@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 24, 2013

Contributor

Me me me! I want to try writing tests. Just give me brief intro. I have
some testing before but never in Ruby.

Contributor

aniketpant commented Sep 24, 2013

Me me me! I want to try writing tests. Just give me brief intro. I have
some testing before but never in Ruby.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2013

Member

Take a look at the other files in test/. You're going to want to add a test/test_jrnl_importer.rb that takes "fake" data and ensures that the output is correct. Try to just make sure you get the logic right (may need to refactor the class into more methods for easier testing) so that when we make changes, we don't muck anything up in the future. Oh and please try to avoid I/O (so no writing of the files).

Member

parkr commented Sep 24, 2013

Take a look at the other files in test/. You're going to want to add a test/test_jrnl_importer.rb that takes "fake" data and ensures that the output is correct. Try to just make sure you get the logic right (may need to refactor the class into more methods for easier testing) so that when we make changes, we don't muck anything up in the future. Oh and please try to avoid I/O (so no writing of the files).

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2013

Member

:D

Member

parkr commented Sep 24, 2013

:D

@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 24, 2013

Contributor

Got it. Will write tests and let you know. If I have any doubts/questions,
will ask you on Twitter.

Contributor

aniketpant commented Sep 24, 2013

Got it. Will write tests and let you know. If I have any doubts/questions,
will ask you on Twitter.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2013

Member

Sounds good! Or email me parker AT parkermoo.re

Member

parkr commented Sep 24, 2013

Sounds good! Or email me parker AT parkermoo.re

aniketpant added some commits Sep 24, 2013

Fix silly typo
Signed-off-by: Aniket Pant <me@aniketpant.com>
Update methods in compliance to tests
Signed-off-by: Aniket Pant <me@aniketpant.com>
Add tests
Signed-off-by: Aniket Pant <me@aniketpant.com>
@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 25, 2013

Contributor

@parkr Wrote the tests. Take a look at them and see if they do the job.

P.S. I wish we had mocha and chai for Ruby.

Contributor

aniketpant commented Sep 25, 2013

@parkr Wrote the tests. Take a look at them and see if they do the job.

P.S. I wish we had mocha and chai for Ruby.

@mattr-

View changes

Show outdated Hide outdated lib/jekyll/jekyll-import/jrnl.rb
# Returns array converted to YAML
def self.create_meta(layout, title, date)
data = {
'layout' => layout.to_s,

This comment has been minimized.

@mattr-

mattr- Sep 25, 2013

Member

The calls to to_s aren't needed here or on the line below. You're already working with Strings.

@mattr-

mattr- Sep 25, 2013

Member

The calls to to_s aren't needed here or on the line below. You're already working with Strings.

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Sep 25, 2013

Member

Looks good to me, other than one small nit.

Member

mattr- commented Sep 25, 2013

Looks good to me, other than one small nit.

Fix unrequired string conversions
Signed-off-by: Aniket Pant <me@aniketpant.com>
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 25, 2013

Member

Looks like the tests aren't passing on Travis. Did you commit all your files and push up the latest?

Member

parkr commented Sep 25, 2013

Looks like the tests aren't passing on Travis. Did you commit all your files and push up the latest?

@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 25, 2013

Contributor

Yeah. I did. Could you please look into what's wrong?

I know that I should've removed that date test but that can't be the
reason as it passed OK on local.

Contributor

aniketpant commented Sep 25, 2013

Yeah. I did. Could you please look into what's wrong?

I know that I should've removed that date test but that can't be the
reason as it passed OK on local.

@parkr

View changes

Show outdated Hide outdated test/test_jrnl_importer.rb
end
should "have date" do
assert_equal("2013-09-24 11:36:00 +0530", "#{JekyllImport::Jrnl.get_date(@entry[0], @date_length)}")

This comment has been minimized.

@parkr

parkr Sep 26, 2013

Member

You'll need to build a Time object instead of just comparing to this String. :)

@parkr

parkr Sep 26, 2013

Member

You'll need to build a Time object instead of just comparing to this String. :)

This comment has been minimized.

@aniketpant

aniketpant Sep 26, 2013

Contributor

Why so?

The method returns a string on it's own.

@aniketpant

aniketpant Sep 26, 2013

Contributor

Why so?

The method returns a string on it's own.

This comment has been minimized.

Fix date test
Signed-off-by: Aniket Pant <me@aniketpant.com>
@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 26, 2013

Contributor

@parkr The test is still failing. I am not sure what is the problem because I have changed the test now.

Contributor

aniketpant commented Sep 26, 2013

@parkr The test is still failing. I am not sure what is the problem because I have changed the test now.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 26, 2013

Member

Ha! I had a feeling that was going to come back to bite us in the butt.

[ 2/31] TestJrnlMigrator#test: jrnl should have date.  = 0.05 s
  1) Failure:
test: jrnl should have date. (TestJrnlMigrator) [/Users/parkermoore/code/jekyll-import/test/test_jrnl_importer.rb:23]:
<2013-09-24 02:06:00 -0400> expected but was
<2013-09-24 11:36:00 -0400>.

(As a side note, the first argument in assert_equals is the actual value, the second arg is the expected value.)

Why don't we make a decision to just change this such that it extracts the string and puts the string from the jrnl line and outputs it as-is?

Member

parkr commented Sep 26, 2013

Ha! I had a feeling that was going to come back to bite us in the butt.

[ 2/31] TestJrnlMigrator#test: jrnl should have date.  = 0.05 s
  1) Failure:
test: jrnl should have date. (TestJrnlMigrator) [/Users/parkermoore/code/jekyll-import/test/test_jrnl_importer.rb:23]:
<2013-09-24 02:06:00 -0400> expected but was
<2013-09-24 11:36:00 -0400>.

(As a side note, the first argument in assert_equals is the actual value, the second arg is the expected value.)

Why don't we make a decision to just change this such that it extracts the string and puts the string from the jrnl line and outputs it as-is?

@aniketpant

This comment has been minimized.

Show comment
Hide comment
@aniketpant

aniketpant Sep 26, 2013

Contributor

@parkr What do you mean by the last part? Sorry, I didn't understand that.

Contributor

aniketpant commented Sep 26, 2013

@parkr What do you mean by the last part? Sorry, I didn't understand that.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 26, 2013

Member

Read in the (time) string, output the same string. Don't convert at all.

Member

parkr commented Sep 26, 2013

Read in the (time) string, output the same string. Don't convert at all.

Change get_date code to fix issue with test
Signed-off-by: Aniket Pant <me@aniketpant.com>
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 29, 2013

Member

Boom! LGTM. @mattr-?

Member

parkr commented Sep 29, 2013

Boom! LGTM. @mattr-?

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 3, 2013

Member

Cool. Thanks! 💚

Member

mattr- commented Oct 3, 2013

Cool. Thanks! 💚

mattr- added a commit that referenced this pull request Oct 3, 2013

Merge pull request #51 from aniketpant/import-jrnl
New Feature: Import jrnl files

@mattr- mattr- merged commit 74005bd into jekyll:master Oct 3, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Oct 3, 2013

@aniketpant aniketpant deleted the aniketpant:import-jrnl branch Oct 4, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.