MovableType export: adding comments #66
Conversation
|
This is pretty cool. |
|
I've finally start using sites creating this plugin and template and pretty much satisfied. I think it is worth to merge. |
|
👍 from me. |
|
@shigeya Would you mind rebasing this to current master and force pushing to your branch so we can do an automatic merge? |
|
Sure. Work on it right now. |
|
Hmm. you've changed overall structure a lot. will require little more time than I expected. Will work on this in a day or two and update this pull request. (Merge done but can't verify the result since invocation scheme is now different..) |
|
Don't have enough to work on this.. After I pushed I realised I need to change option parsing. will push another one soon. |
- comments option added (currently default false) - metadata for entry added: blog_id, post_id, mt_id, basename note: post_id is same as mt_id. for the comment plugin - comments formats are same as posts: with YAML front matter - comment related metadata/content output methods and path generators - also fixes default option processing order
|
Fixed all (including comments). Produces exactly same output as my previous version does. |
| @@ -21,7 +21,8 @@ def self.default_options | |||
| :blog_id => nil, | |||
| :categories => true, | |||
| :dest_encoding => 'utf-8', | |||
| :src_encoding => 'utf-8' | |||
| :src_encoding => 'utf-8', | |||
| :comments => false | |||
There was a problem hiding this comment.
These default options are going to have to use string keys or the values won't override!
There was a problem hiding this comment.
Oh, then, this code was not working anyway now... Will change all of then and will push..
|
Great! Just one comment about then it's good to 🚢. |
|
Replaced option related symbols to string |
|
Great! This LGTM. Would you mind quickly adding the new |
|
Hi, added docs. Happy holidays:) |
|
LGTM!! @mattr-? Happy holidays :) |
|
Thank you:) |
|
Thank YOU! Great work on this PR :) |
I have created a set of patches which allow me to export comments from MovableType site.
The code here adds some IDs to files generated in _posts directory, and also exports comments in _comments directory.
By applying templates and plugin (https://github.com/shigeya/jekyll-static-comments/tree/mt_static_comments) to the output of this modified plugin, I can statically generate comments to each posts, from the export origin site.