Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MovableType export: adding comments #66

Closed
wants to merge 3 commits into from

Conversation

@shigeya
Copy link
Contributor

shigeya commented Nov 2, 2013

I have created a set of patches which allow me to export comments from MovableType site.

The code here adds some IDs to files generated in _posts directory, and also exports comments in _comments directory.

By applying templates and plugin (https://github.com/shigeya/jekyll-static-comments/tree/mt_static_comments) to the output of this modified plugin, I can statically generate comments to each posts, from the export origin site.

@parkr
Copy link
Member

parkr commented Dec 11, 2013

This is pretty cool.

@shigeya
Copy link
Contributor Author

shigeya commented Dec 12, 2013

I've finally start using sites creating this plugin and template and pretty much satisfied. I think it is worth to merge.

@mattr-
Copy link
Member

mattr- commented Dec 12, 2013

👍 from me.

@mattr-
Copy link
Member

mattr- commented Dec 12, 2013

@shigeya Would you mind rebasing this to current master and force pushing to your branch so we can do an automatic merge?

@shigeya
Copy link
Contributor Author

shigeya commented Dec 12, 2013

Sure. Work on it right now.

@shigeya
Copy link
Contributor Author

shigeya commented Dec 12, 2013

Hmm. you've changed overall structure a lot. will require little more time than I expected. Will work on this in a day or two and update this pull request. (Merge done but can't verify the result since invocation scheme is now different..)

@shigeya
Copy link
Contributor Author

shigeya commented Dec 22, 2013

Don't have enough to work on this.. After I pushed I realised I need to change option parsing. will push another one soon.

- comments option added (currently default false)
- metadata for entry added: blog_id, post_id, mt_id, basename
  note: post_id is same as mt_id. for the comment plugin
- comments formats are same as posts: with YAML front matter
- comment related metadata/content output methods and path generators
- also fixes default option processing order
@shigeya

This comment has been minimized.

Copy link
Owner Author

shigeya commented on lib/jekyll-import/importers/mt.rb in 4ca0daa Dec 22, 2013

This line should be before all options.fetch calls. I added fixes to this, too.

@shigeya
Copy link
Contributor Author

shigeya commented Dec 22, 2013

Fixed all (including comments). Produces exactly same output as my previous version does.

@@ -21,7 +21,8 @@ def self.default_options
:blog_id => nil,
:categories => true,
:dest_encoding => 'utf-8',
:src_encoding => 'utf-8'
:src_encoding => 'utf-8',
:comments => false

This comment has been minimized.

Copy link
@parkr

parkr Dec 22, 2013

Member

These default options are going to have to use string keys or the values won't override!

This comment has been minimized.

Copy link
@shigeya

shigeya Dec 22, 2013

Author Contributor

Oh, then, this code was not working anyway now... Will change all of then and will push..

@parkr
Copy link
Member

parkr commented Dec 22, 2013

Great! Just one comment about then it's good to 🚢.

@shigeya
Copy link
Contributor Author

shigeya commented Dec 22, 2013

Replaced option related symbols to string

@parkr
Copy link
Member

parkr commented Dec 22, 2013

Great! This LGTM. Would you mind quickly adding the new comments option to the movable type docs page? It's site/docs/mt.md, I think.

@shigeya
Copy link
Contributor Author

shigeya commented Dec 23, 2013

Hi, added docs. Happy holidays:)

@parkr
Copy link
Member

parkr commented Dec 23, 2013

LGTM!! @mattr-?

Happy holidays :)

@parkr parkr closed this in 881640a Dec 26, 2013
parkr added a commit that referenced this pull request Dec 26, 2013
@shigeya
Copy link
Contributor Author

shigeya commented Dec 26, 2013

Thank you:)

@parkr
Copy link
Member

parkr commented Dec 26, 2013

Thank YOU! Great work on this PR :)

parkr added a commit that referenced this pull request Jan 11, 2014
parkr added a commit that referenced this pull request Apr 14, 2016
Merges #66. Closes #66
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
antonizoon pushed a commit to antonizoon/jekyll-import that referenced this pull request Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.