Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate output for paginate_path fix #8 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

validate output for paginate_path fix #8 #10

wants to merge 1 commit into from

Conversation

rusikf
Copy link
Contributor

@rusikf rusikf commented Sep 1, 2014

No description provided.

@rusikf
Copy link
Contributor Author

rusikf commented Sep 1, 2014

to pass Travis CI , merge my previous pull request 😏

@parkr
Copy link
Member

parkr commented Sep 1, 2014

Don't you think this kind of sanitization should occur in the URL class (and that we should use URL for handling url generation in this class)?

@rusikf
Copy link
Contributor Author

rusikf commented Sep 2, 2014

But colons is safe in url,
why we must sanitize it?
I think colons in url must be allowed , but writing paginate_path with colons in config.yml must not be allowed.
May be it should occure in Pager#initialize ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rusikf @parkr