Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure redirect_to links produce an HTML file. #111

Merged
merged 2 commits into from
Jun 22, 2016

Conversation

parkr
Copy link
Member

@parkr parkr commented Jun 15, 2016

Debugging @gboone's 18f.gsa.gov site, I noticed this:

$ tree _site/tags/how\ we\ work
_site/tags/how\ we\ work/
├── index
├── index.html

I had seen something like this before due to #96. The problem is a naïve File.basename(permalink), which takes how we work from /tags/how we work/ instead of /. By appending an index.html, we ensure that the redirect page has the proper basename to be properly created.

Fixes #107.

@benbalter
Copy link
Contributor

LGTM, pending the merge conflict.

@parkr parkr force-pushed the fix-redirect-to-non-html-page branch from bc399fd to d3b5393 Compare June 22, 2016 22:09
@parkr
Copy link
Member Author

parkr commented Jun 22, 2016

@benbalter: rebased.

@benbalter
Copy link
Contributor

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 79aad7c into master Jun 22, 2016
@jekyllbot jekyllbot deleted the fix-redirect-to-non-html-page branch June 22, 2016 22:16
jekyllbot added a commit that referenced this pull request Jun 22, 2016
@jekyll jekyll locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redirect_to appears not to work
3 participants