Skip to content

Commit

Permalink
Remove extra newline in css output (#144)
Browse files Browse the repository at this point in the history
Merge pull request 144
  • Loading branch information
ntkme committed Dec 8, 2022
1 parent 13d2054 commit d0e46da
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions lib/jekyll/converters/scss.rb
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,14 @@ def sass_configs

def convert(content)
output = ::Sass.compile_string(content, **sass_configs)
result = +"#{output.css}\n"
result = output.css

if sourcemap_required?
source_map = process_source_map(output.source_map)
generate_source_map_page(source_map)

if (sm_url = source_mapping_url)
result << "\n/*# sourceMappingURL=#{sm_url} */"
result += "#{sass_style == :compressed ? "" : "\n\n"}/*# sourceMappingURL=#{sm_url} */"
end
end

Expand Down
6 changes: 3 additions & 3 deletions spec/sass_converter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
end

let(:expanded_css_output) do
<<~CSS
<<~CSS.chomp
body {
font-family: Helvetica, sans-serif;
font-color: fuschia;
Expand Down Expand Up @@ -67,13 +67,13 @@ def converter(overrides = {})
it "does not include the charset without an associated page" do
overrides = { "style" => :expanded }
result = converter(overrides).convert(%(a\n content: "あ"))
expect(result).to eql(%(a {\n content: "あ";\n}\n))
expect(result).to eql(%(a {\n content: "あ";\n}))
end

it "does not include the BOM without an associated page" do
overrides = { "style" => :compressed }
result = converter(overrides).convert(%(a\n content: "あ"))
expect(result).to eql(%(a{content:"あ"}\n))
expect(result).to eql(%(a{content:"あ"}))
expect(result.bytes.to_a[0..2]).not_to eql([0xEF, 0xBB, 0xBF])
end
end
Expand Down
8 changes: 4 additions & 4 deletions spec/scss_converter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
end

let(:expanded_css_output) do
<<~CSS
<<~CSS.chomp
body {
font-family: Helvetica, sans-serif;
font-color: fuschia;
Expand Down Expand Up @@ -135,13 +135,13 @@ def converter(overrides = {})
it "does not include the charset without an associated page" do
overrides = { "style" => :expanded }
result = converter(overrides).convert(%(a{content:"あ"}))
expect(result).to eql(%(a {\n content: "あ";\n}\n))
expect(result).to eql(%(a {\n content: "あ";\n}))
end

it "does not include the BOM without an associated page" do
overrides = { "style" => :compressed }
result = converter(overrides).convert(%(a{content:"あ"}))
expect(result).to eql(%(a{content:"あ"}\n))
expect(result).to eql(%(a{content:"あ"}))
expect(result.bytes.to_a[0..2]).not_to eql([0xEF, 0xBB, 0xBF])
end
end
Expand All @@ -156,7 +156,7 @@ def converter(overrides = {})

it "imports SCSS partial" do
expect(File.read(test_css_file)).to eql(
".half{width:50%}\n\n/*# sourceMappingURL=main.css.map */"
".half{width:50%}/*# sourceMappingURL=main.css.map */"
)
end

Expand Down

0 comments on commit d0e46da

Please sign in to comment.