Different philosophy for rel prev/next links based on recommendations from Google #87
Conversation
… from Google. Details here: https://webmasters.googleblog.com/2011/09/pagination-with-relnext-and-relprev.html. This replaces the per-page prev/next links with general ones that will be output whenever there is a paginator with a previous or next page to show.
|
Looks like Before this can be merged, we will need to add some tests. Are you able to add some specs to Edit: Sorry for closing. My fat thumb hit the wrong button 😡 |
|
Apparently we had no tests for the old way, since removing it didn't break anything 😶 |
|
Yes, that's why I didn't write any for this change... I'll see if I can find some time for it tomorrow. |
|
I would love to merge this. @tfe will you have some time to write some tests? |
…ting. Backwards-compatible with previous implementation.
|
It took quite a bit of trial-and-error and poking around to figure out how to correctly stub the paginator for testing, but there it is. :) |
|
Oops, stand by. |
|
OK, green now. So I'm sure you thought of this, but this is a breaking change to the existing pagination behavior probably worthy of a version number bump. |
@tfe could you elaborate a bit? Does it break configuration at all, or just changes the output? |
|
@benbalter It only changes the output, not the interface. @tfe Thinking a bit more about this, I think one could make a strong argument that this is merely a bugfix rather than a breaking change. That said, I think this will be a big enough change that we need to very clearly communicate what is happening and why. I guess I could go either way as far as major/minor version bump. |
|
I agree, we can call this a bug fix, but am fine making this a minor bump if we think it warrants it. |
|
Doesn't matter to me; I have no skin in the game. I just wanted to make sure you and the other maintainers thought about it before hitting merge. |
|
LGTM. @pathawks do you think it needs a major bump, or is a minor bump sufficient? (I'd even be fine with calling it a bug fix, as long as we communicate the change in behavior). I can't see how this would break any site, even if it is a change in behavior. |
|
Lets do a minor bump. This is bigger than just a patch release because it changes the behavior in a way we need to be sure to communicate, but no big API changes 👍 |
|
Thanks @tfe! Nice work. |
Details here: https://webmasters.googleblog.com/2011/09/pagination-with-relnext-and-relprev.html.
This replaces the per-page prev/next links with general ones that will be output whenever there is a paginator with a previous or next page to show. I like the idea of leaning on the paginator to know when there is a previous or next page to link to.
Also resolves #80.