Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document compatibility with jekyll-last-modified-at #104

Closed
FrederikLauber opened this issue Apr 3, 2016 · 14 comments
Closed

Document compatibility with jekyll-last-modified-at #104

FrederikLauber opened this issue Apr 3, 2016 · 14 comments

Comments

@FrederikLauber
Copy link

Hi,

it seems that lastmod does not reflect the changes in a file anymore.
Instead, it always stays constant.

Example:
https://flambda.de/sitemap.xml
Look for:

<url><loc>https://flambda.de/2013/08/25/pendel-time-calculations/</loc><lastmod>2013-08-25T21:40:00+02:00</lastmod></url>

The page has been updated multiple times since 2013, still, lastmod has the same value as the date field in the yaml of the post. (21:40 is specified in the yaml).

With best regards,

@pathawks
Copy link
Member

pathawks commented Apr 3, 2016

<lastmod> Will only reflect the modified date of the file as reported by the filesystem if you have jekyll-last-modified-at installed. It looks like this is not stated anywhere in our documentation; we should probably make a note of that somewhere.

@pathawks pathawks closed this as completed Apr 3, 2016
@pathawks pathawks changed the title lastmod is incorrect Document compatibility with jekyll-last-modified-at Apr 3, 2016
@pathawks pathawks reopened this Apr 3, 2016
@parkr
Copy link
Member

parkr commented Apr 14, 2016

we should probably make a note of that somewhere.

👍

@GitHub-Mike
Copy link

The timestamp is up to date now!?

https://flambda.de/sitemap.xml

Issue opener used a other tool now or the issue can be closed.

Mike

@pathawks
Copy link
Member

<lastmod> Will only reflect the modified date of the file as reported by the filesystem if you have jekyll-last-modified-at installed. It looks like this is not stated anywhere in our documentation; we should probably make a note of that somewhere.

@FrederikLauber
Copy link
Author

Excatly what pathawks said.

After I had opened this bug not knowing anything about the dependency on jekyll-last-modified-at, I was told to install this here in this bug and hence, now the sitemap is correct.

Should I either open a new bug with a request to alter the documentation to include this very important information or should this bug just stay open until the documentation includes the information?

@pathawks
Copy link
Member

I changed the title of the issue, and I’m keeping this issue open as a reminder for myself to change the docs. If somebody else beats me to it, that’s cool too 👍

@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least
one month.

The resources of the Jekyll team are limited, and so we are asking for your help.

If you can still reproduce this error on the 3.1-stable or master branch,
please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced
hooks which provide convenient access points throughout
the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be
built as a plugin, then please provide more information about why in order to keep this issue open.

Thank you for all your contributions.

@parkr
Copy link
Member

parkr commented Jun 13, 2016

@pathawks Would you mind updating this soon? No need for a PR if you don't want to do that part of the dance – just push straight to master. 😄

@jekyllbot jekyllbot removed the stale label Jun 13, 2016
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@pathawks
Copy link
Member

@jekyllbot Not stale; just been busy. Sorry, will try to tackle this in the next few days.

@jekyllbot jekyllbot removed the stale label Aug 14, 2016
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@pathawks
Copy link
Member

Thanks for the reminder @jekyllbot

@jekyllbot jekyllbot removed the stale label Oct 14, 2016
@oncleben31
Copy link
Contributor

If we don't have the jekyll-last-modified-at plugin, is it possible to add the information in the Front Matter ?

@oncleben31
Copy link
Contributor

If we don't have the jekyll-last-modified-at plugin, is it possible to add the information in the Front Matter ?

Answer is Yes. And I've created the PR for the documentation 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants