Add --force flag to new command #1115
Merged
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've noticed |
| @@ -3,12 +3,12 @@ | |||
| module Jekyll | |||
| module Commands | |||
| class New < Command | |||
| def self.process(args) | |||
| def self.process(args, options = {}) | |||
| raise ArgumentError.new('You must specify a path.') if args.empty? | |||
|
|
|||
| new_blog_path = File.expand_path(args.join(" "), Dir.pwd) | |||
There was a problem hiding this comment.
In your tests, did args include --force?
There was a problem hiding this comment.
No, flags were properly separated from args. If you ran the command with only the force flag args would simply be an empty array. Commander is nice enough to ensure this in their specs.
|
This looks good to me. @mattr-, if everything checks out for you as well, merge it in! :) |
|
Nice work @clang1234 ! Thanks! ❤️ 🚢ed |
mattr-
added a commit
that referenced
this pull request
May 18, 2013
Add --force flag to new command
mattr-
added a commit
that referenced
this pull request
May 18, 2013
|
Thanks guys! Glad I could help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1104, I've added a
--forcecommand to thenewsubcommand.