Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documented new gem 'jekyll_image_encode' in the plugins list #1405

Merged
merged 1 commit into from Oct 27, 2013

Conversation

GSI
Copy link

@GSI GSI commented Aug 10, 2013

No description provided.

@parkr
Copy link
Member

parkr commented Aug 10, 2013

LGTM. @mattr-?

Any reason you didn't just put it at the bottom of the list?

@GSI
Copy link
Author

GSI commented Aug 10, 2013

@parkr Apart from "I was unable to identify the sorting concept" I just aligned it alphabetically with the other plugin that started with Jekyll Image ... :)

@mattr-
Copy link
Member

mattr- commented Aug 14, 2013

I merged a bunch of other documentation pull requests. Would you mind rebasing this against current master so we can just hit the giant green button? Thanks! ❤️

@ghost ghost assigned parkr Oct 23, 2013
@GSI
Copy link
Author

GSI commented Oct 26, 2013

As requested, the updated commit - now including a total of three additional plugins

@parkr
Copy link
Member

parkr commented Oct 26, 2013

LGTM

mattr- added a commit that referenced this pull request Oct 27, 2013
documented new gem 'jekyll_image_encode' in the plugins list
@mattr- mattr- merged commit 4d1a697 into jekyll:master Oct 27, 2013
@mattr-
Copy link
Member

mattr- commented Oct 27, 2013

💥 Merged! Thanks!

mattr- added a commit that referenced this pull request Oct 27, 2013
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants