Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included file not found error leaks full path to source directory #1950

Closed
benbalter opened this issue Jan 14, 2014 · 3 comments · Fixed by #1951
Closed

Included file not found error leaks full path to source directory #1950

benbalter opened this issue Jan 14, 2014 · 3 comments · Fixed by #1951
Milestone

Comments

@benbalter
Copy link
Contributor

Seems that since #1841 (and released with 1.4.3), requests for included files that do not exist within the _includes directory leak the absolute path to the source, not the relative path to the requesting file as they did before (and all other errors do).

Steps to reproduce

  1. Create an `index.html file
  2. Add {% include missing.html %} to it (don't create the missing file, duh)
  3. jekyll build

Expected output:

Liquid Exception: Included file 'missing-file.html' not found in index.html

Actual output

Liquid Exception: Included file '/Users/benbalter/.../missing-file.html' not found in index.html

/cc @jens-na

@parkr
Copy link
Member

parkr commented Jan 14, 2014

Need this now or can we punt until 2.0.0?

@benbalter
Copy link
Contributor Author

Minor, although theoretically a security concern if not properly sanitized elsewhere. May be a liquid thing all together.

@mattr-
Copy link
Member

mattr- commented Jan 14, 2014

(don't create the missing file, duh)

❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants