Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jekyll clean doesn't understand --config #3744

Closed
lboecker opened this issue May 28, 2015 · 6 comments
Closed

jekyll clean doesn't understand --config #3744

lboecker opened this issue May 28, 2015 · 6 comments

Comments

@lboecker
Copy link

I'm using 3.0.0.pre.beta5

jekyll clean -s src -d build doesn't work either.


config.yml is at the root of the source tree; the commands are executed from the root as well.

@lboecker
Copy link
Author

lboecker commented Jun 4, 2015

By the way: Is clean supposed to remove stuff listed in keep_files?

@envygeeks
Copy link
Contributor

I don't know if it is but I'd be happy to look into it this week since I would like to integrate the clean command into my build setup. Maybe @parkr can provide some input?

@envygeeks envygeeks reopened this Jun 4, 2015
@parkr
Copy link
Member

parkr commented Jun 4, 2015

By the way: Is clean supposed to remove stuff listed in keep_files?

Nope.

It should definitely take the build commands. There's a method on Jekyll::Command for that, I think.

@lboecker
Copy link
Author

lboecker commented Jun 4, 2015

IIRC (big if) I got the clean command to work one way or another and it removed everything, but please don't take my word for it.

I'm not a ruby guy, but I looked at the source and it looks like it's doing what it's supposed to be doing (i.e., calling configuration_from_options like the other commands). I guess calling configuration_from_options isn't good enough and you'd have to (re-)add them using add_build_options or something?

@lboecker
Copy link
Author

Did anybody have a chance to look into this? It would be really nice to get this into 3.0 and it shouldn't be too hard to fix.

@parkr
Copy link
Member

parkr commented Jun 30, 2015

Yeah check out command.rb. There's a method in there that should be called by the clean command. Use the build or serve commands as an example.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants