New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest an overwriting warning. #4023
Comments
Oh man, I'm sorry to hear that! It always sucks to love your files. What command did you use? |
jekyll build -d /var/www (it should be a subdirectory in www), so you know... |
We would have to find a way to differentiate internally over whether or not you set the directory or we set the directory because that message hinders normal behavior (re: _site) by warning because it probably will never be empty after the first build, unless you clean. |
Yes, I'm just suggesting to have a warning like "The directory you are going to write is not empty, overwrite? (n)" |
And that's exactly what I'm trying to avoid, the (n) implies it's a prompt which would get annoying for a standard Jekyll user. Actually, it's quite unintuitive with our own default folders. |
Let me clarify, by avoid I mean only prompt for a non-standard write folder, I do like the idea in general of asking if it's fine to overwrite, just not if we are writing to |
I think if you use |
I don't know if that's bad UX or not because by nature we overwrite. I'm not against it, I just don't know if that's bad UX because of the nature of what we do. Ultimately though on our systems I think I would much prefer a mixture between the two ideas if |
I think --force will be great. Enter a --force after the destination directory allows you to double-check it. |
Shouldn't we use something like |
On a note: whether or not you add something to our commands is not something we should consider when making our switches. Not to be mean, but we cannot possibly foresee what you might do and we don't necessarily want to support changes you make (that is a personal stance and is not reflective of the entirey of everybody else -- because it's your job to support those changes.) |
@envygeeks thanks for the feedback. I have to admit |
That's a great idea! @Leo2807 |
I was building a page with jekyll on my server, but I just accidentally typed in a wrong directory and it just overwrited anything in that dir. All my things just gone in a second, and it is hard to recover them. I know it's my fault to use root permission but I really want an overwrite warning for writing into a non-empty directory.
A lot thanks.
The text was updated successfully, but these errors were encountered: