Clean up many test files to pass Rubocop rules #4902
Conversation
| end | ||
| end | ||
|
|
||
| context "not-nested directory in keep_files and similary named directory not in keep_files" do | ||
| context "not-nested directory in keep_files and similary named directory not "\ | ||
| "in keep_files" do |
There was a problem hiding this comment.
let's try to just shorten this name. super confusing haha. how about
non-nested directory & similarly-named directory *not* in keep_files
does that work here?
There was a problem hiding this comment.
Fix committed locally (documenting this so I can keep track of what's done)
|
Hey @brint, thanks so much for your pull request! I have some things I'd like for you to fix up before we merge this, but it's looking great! We'll merge it once the comments I left are addressed. Thank you! 😄 |
This commit cleans up rubocop violations for the following files: test/test_ansi.rb test/test_cleaner.rb test/test_coffeescript.rb test/test_collections.rb test/test_command.rb test/test_commands_serve.rb
|
Sounds good! Doing the cleanup, I've rebased to pick up some of the new rules. Some of these lines were one or two characters over the 90 |
Ah ok. Feel free to rephrase some of the suggestions so they're less than 90 characters. Thank you! |
parkr
changed the title
|
Lookin' good to me, thanks @brint! @jekyllbot: merge +dev |
This PR cleans up rubocop violations for the following files:
test/helper.rb
test/simplecov_custom_profile.rb
test/test_ansi.rb
test/test_cleaner.rb
test/test_coffeescript.rb
test/test_collections.rb
test/test_command.rb
test/test_commands_serve.rb
test/test_convertible.rb
test/test_doctor_command.rb
test/test_excerpt.rb
test/test_front_matter_defaults.rb
test/test_generated_site.rb
test/test_layout_reader.rb
test/test_liquid_extensions.rb
test/test_log_adapter.rb
test/test_new_command.rb
test/test_path_sanitization.rb
test/test_plugin_manager.rb
test/test_rdiscount.rb
test/test_redcarpet.rb