Add fetch method to Drops #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -199,6 +199,10 @@ def merge!(other) | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| def fetch(*args, &block) | |||
| to_h.fetch(*args, &block) | |||
There was a problem hiding this comment.
#to_h is an expensive operation. Could we mimic the behaviour without having to actually create a hash?
|
This LGTM. @jekyll/core? |
|
|
|
Thanks @envygeeks :) @jekyllbot: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Jul 7, 2016
stevecheckoway
pushed a commit
to stevecheckoway/jekyll
that referenced
this pull request
Jul 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4615
As pointed out by @parkr - added
fetchmethod toDrops::Dropclass.