Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll serving unexpected URL #5061

Closed
5 of 17 tasks
mneumegen opened this issue Jul 6, 2016 · 10 comments
Closed
5 of 17 tasks

Jekyll serving unexpected URL #5061

mneumegen opened this issue Jul 6, 2016 · 10 comments
Labels
frozen-due-to-age stale Nobody stepped up to work on this issue.

Comments

@mneumegen
Copy link
Contributor

mneumegen commented Jul 6, 2016

  • I believe this to be a bug, not a question about using Jekyll.
  • I Updated to the latest Jekyll (or) if on Github Pages to the latest github-pages
  • I Read the CONTRIBUTION file at https://jekyllrb.com/docs/contributing/
  • This is a feature request.

  • I am on (or have tested on) _macOS_ 10+
  • I am on (or have tested on) _Debian/Ubuntu_ GNU/Linux
  • I am on (or have tested on) _Fedora_ GNU/Linux
  • I am on (or have tested on) _Arch_ GNU/Linux
  • I am on (or have tested on) _Other_ GNU/Linux
  • I am on (or have tested on) _Windows_ 10+

  • I was trying to install.
  • There is a broken Plugin API.
  • I had an error on Github Pages, and I have not tested locally.
  • I had an error on Github Pages, and Github Support said it was a Jekyll Bug.
  • I had an error on Github Pages and I did not test it locally.
  • I was trying to build.
  • It was another bug.

My Reproduction Steps

  1. Create a site with a index.html.
  2. Run jekyll serve.
  3. In a browser navigate to http://localhost:4000/index/put/anything/here/ and it will serve /index.html.

The Output I Wanted

I would expect this URL to 404. It's caused confusion among users.

@parkr
Copy link
Member

parkr commented Jul 6, 2016

@mneumegen Did you test on master? Here's the code which looks up the path.

@parkr parkr added the bug label Jul 6, 2016
@mneumegen
Copy link
Contributor Author

@parkr Yip tested on jekyll 3.2.0.pre.beta1.

I tried changing the line you suggested to:

super || super(req, res, "#{req.path_info.scan(%r|/[^/]*|).last}.html")

And it solves the problem and works for the other cases (/file.* > /file/index.html > /file.html). This comes from having a quick look at how WEBrick works so I'm not sure of the full implications of this change.

@parkr
Copy link
Member

parkr commented Jul 7, 2016

/cc @envygeeks who worked on the servlet.

@envygeeks
Copy link
Contributor

@mneumegen @parkr you're right, that is a slight bug, might be easier to use res.filename if I remember right.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Sep 7, 2016
@envygeeks
Copy link
Contributor

I don't remember if we ever resolved this bug?

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Sep 7, 2016
@DirtyF
Copy link
Member

DirtyF commented Sep 7, 2016

@envygeeks after a quick test, I can confirm that this bug is still unresolved. You can request /index/whatever/you/want and Jekyll won't mind on the local server. In production it won't respond to the request though.

@JazzMaster
Copy link

also see the / bug I just reported. jekyll wants it, theres no way in hell its getting /

. or .. maybe... not (root of the drive). I dont know about sin, but on unice thats where that points.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Nov 13, 2016
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the 3.1-stable or master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@DirtyF DirtyF removed the stale Nobody stepped up to work on this issue. label Nov 13, 2016
@DirtyF
Copy link
Member

DirtyF commented Nov 13, 2016

This minor bug is still present in Jekyll 3.3.0

/cc @jekyll/core

@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the 3.3-stable or master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Jan 13, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age stale Nobody stepped up to work on this issue.
Projects
None yet
Development

No branches or pull requests

6 participants