theme.gemspec doesn't build theme gem properly

[ashmaroli]

• I believe this to be a bug, not a question about using Jekyll.
• I updated to the latest Jekyll (or) if on GitHub Pages to the latest github-pages
• I read the CONTRIBUTION file at https://jekyllrb.com/docs/contributing/
• This is not a feature request.

---

• I am on (or have tested on) _Windows 7_

---

• I was trying to build the theme gem.

My Reproduction Steps

• Create new theme, titan:

$ jekyll new-theme titan

• cd into theme dir and add a file each to empty subdirs.
• edit titan.gemspec to prepare for building gem
• update git index by running:

$ git add .

• Build gem.

$ gem build titan.gemspec

  Successfully built RubyGem
  Name: titan
  Version: 0.1.0
  File: titan-0.1.0.gem

• unpack gem contents to verify build before publishing:

$ gem unpack titan-0.1.0.gem
Unpacked gem: ~/titan-0.1.0

• cd into the unpacked dir and inspect.

The Output I Wanted

see the necessary files in the unpacked directory.

The Output I Got

an empty directory which means my theme gem was essentially empty.

---

I reached a solution by simply changing the spec.files line in the gemspec to:

  spec.files  = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }

and additionally adding a file each to empty dirs.

---

/cc @jekyll/ecosystem

[benbalter]

I reached a solution by simply changing the spec.files line in the gemspec to:

@ashmaroli this is a great bug report, thank you.

Any interested in submitting a pull request to make that change?

/cc @jekyll/ecosystem

[ashmaroli]

@benbalter thanks 😃 I've already opened a PR at #5325.

[benbalter]

See an alternative approach for minima via jekyll/minima#31 (and related issue jekyll/minima#29.

[ashmaroli]

Fixed in #5325