Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] The Jekyll-Bundler marriage #5684

Closed
ashmaroli opened this issue Dec 24, 2016 · 6 comments
Closed

[Discussion] The Jekyll-Bundler marriage #5684

ashmaroli opened this issue Dec 24, 2016 · 6 comments

Comments

@ashmaroli
Copy link
Member

ashmaroli commented Dec 24, 2016

Hi Guys.
I've been seeing numerous instances of users having issues with Bundler and Jekyll in our support-forum and Issues here. All of those arise from having to install Bundler separately and prepend jekyll commands with bundle exec.
So this discussion is about resolving this hurdler to an extent.

I propose:

  • add 'Bundler' as a dependency
  • internally prepend 'bundle exec' to all jekyll commands

Add 'Bundler' as a dependency

By adding Bundler as a runtime_dependency it will be installed automatically along with Jekyll gem.
So no more cannot load: "bundler" errors..
(I already opened a PR to this effect)

Rewire Jekyll Executable

In theory, it would be better if we add bundle exec to exe/jekyll so that all jekyll commands will be thenceforth automatically run as bundle exec jekyll [command] [...] even if the user enters jekyll [command] [...] in their console.
We could additionally check for Gemfile's absence and fallback to legacy execution to support older sites.

I hope this is not major enough to be put off till v4.0

--
/cc @jekyll/core, @jekyll/ecosystem, @jekyll/stability

@DirtyF
Copy link
Member

DirtyF commented Dec 24, 2016

Isn't this a duplicate of #5660 ?

@ashmaroli
Copy link
Member Author

not a duplicate.. but rather a superset of the same.. I forgot to reference that PR when I added the section on "Add Bundler as a dependency" in the first comment..

@evolve2k
Copy link

Sounds good to me. Should make things simpler for people coming to the ecosystem.
👍

@nickmccurdy
Copy link

Doesn't Rails do something similar with its executable?

@envygeeks
Copy link
Contributor

AFAIW Rails only shims your local executables within your bin directory, and also within a configuration file, of which I think you can disable entirely. I've not tried in years but you used to be able to do it.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Jan 23, 2017
@benbalter benbalter removed their assignment Feb 7, 2017
@parkr
Copy link
Member

parkr commented Mar 31, 2017

We need to be able to support running Jekyll without a Gemfile, so I don't think we can rely on Bundler here, which has a strict reliance on the existence of a Gemfile. Thanks for starting the discussion!

@parkr parkr closed this as completed Mar 31, 2017
@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Mar 31, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants