Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop 47 adds new security cops that trigger warnings to Jekyll's code:
Marshal.load
orMarshal.restore
due to potential security issues.Q: There is no autocorrect for this cop. Should we ignore this for now or use
Marshal.dump
or another method?YAML.safe_load
overYAML.load
due to potential security issues.Q: Rubocop autocorrect will replace
YAML.load
withYAML.safe_load
but that does trigger a failed test.This PR adds configuration rules to ignore these rules for the concerned files for now, any insight welcome for the best way to handle these security warnings.
/cc @jekyll/core