Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script/backport-pr #5925

Merged
merged 2 commits into from Mar 7, 2017
Merged

Add script/backport-pr #5925

merged 2 commits into from Mar 7, 2017

Conversation

parkr
Copy link
Member

@parkr parkr commented Mar 2, 2017

This is a script I pulled from the git-lfs/git-lfs repo which makes it crazy easy to backport a PR.

Example: #5924

/cc @jekyll/affinity-team-captains @jekyll/core

@parkr parkr added the internal label Mar 2, 2017
@XhmikosR
Copy link
Contributor

XhmikosR commented Mar 3, 2017

I can't really comment on the code itself since it works obviously :)

Only thing I wonder is if it works on Windows but shouldn't really be a blocking issue since most of you guys are on *nix.

#
# Backports a PR into a release branch:
#
# # backport PR #123 into 1.1-stable-backport-1023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did PR #123 morph into 1023?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna guess that's just a typo. 😃

mattr-
mattr- previously requested changes Mar 3, 2017
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get the typo in the comment fixed before approval please?

@parkr parkr dismissed mattr-’s stale review March 7, 2017 02:00

Fixed the typo!

@parkr
Copy link
Member Author

parkr commented Mar 7, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 44c35dc into master Mar 7, 2017
@jekyllbot jekyllbot deleted the backport-pr branch March 7, 2017 02:00
jekyllbot added a commit that referenced this pull request Mar 7, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants