Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: report syntax errors in the web page #6248

Open
osteele opened this issue Jul 26, 2017 · 6 comments
Open

Feature proposal: report syntax errors in the web page #6248

osteele opened this issue Jul 26, 2017 · 6 comments
Labels
has-pull-request Somebody suggested a solution to fix this issue pinned

Comments

@osteele
Copy link
Contributor

osteele commented Jul 26, 2017

Problem: Frequently while running jekyll serve --watch and editing a file, I'll introduce a syntax error and not notice, because I'm just looking back and forth between the editor and the browser, and don't have the terminal in my field of view.

One solution, that requires modifying user behavior, is for the user to have all three panes up and scan them all.

Another is to implement a “syntax error overlay”. The create-react-app project reports syntax errors in the web page, as well as on the console. This PR begins with a screenshot that illustrates this.

This would be a nice feature for Jekyll too. It could look something like this:

screenshot of safari 7-26-17 6-55-08 pm

(This particular screenshot is from a Jekyll clone. That's why the error message is different from what Jekyll would report. I've found it helpful there. If anyone wants to take this on, you are of course welcome to use the clone's CSS and Liquid template.)

@jekyllbot

This comment has been minimized.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Sep 27, 2017
@pathawks
Copy link
Member

This would be pretty cool, so long as it only happened in the dev environment. 👍

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Oct 18, 2017
@jekyllbot

This comment has been minimized.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Dec 18, 2017
@ashmaroli ashmaroli added pinned and removed stale Nobody stepped up to work on this issue. labels Dec 18, 2017
@ashmaroli
Copy link
Member

now that we have core support for livereload, in theory we could achieve this by having a websocket load an /error.html template instead of the actual page at that url..

@jekyllbot

This comment has been minimized.

@nickskalkin
Copy link
Contributor

I want to try to implement this feature, but I'm completely new to jekyll. Can someone give me some advices? :)

@ashmaroli ashmaroli added has-pull-request Somebody suggested a solution to fix this issue and removed help-wanted labels May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-pull-request Somebody suggested a solution to fix this issue pinned
Projects
None yet
Development

No branches or pull requests

6 participants